Do not keep refs to submodules internally#45889
Open
Cyrilvallez wants to merge 3 commits into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45889&sha=f1e81a |
Member
|
Yes not sure it's that useful anyway, + it was causing some issues in downstream libs (peft), I don't feel strongly about keeping it, unless you think it could really be useful down the line @ArthurZucker |
yonigozlan
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. The comment claims to save compute by caching the property, but as it's called on EVERY CHILD in
post_init, we actually traverse the entire graph for every child, instead of traversing it only once during conversion search.Also, keeping internal refs to submodules themselves is IMO a bad idea in general (the property contains both the string AND the module itself)
cc @yonigozlan @ArthurZucker